Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP // Export xlsx FSP auth code (MTCN) #4527

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Dec 17, 2024

  • AB#225622: Payment Module - Enhancements for API-based FSPs

  • unit tests/coverage

  • AB#228316: FE changes

New Perms added: PM_DOWNLOAD_MTCN, PM_SEND_XLSX_PASSWORD

templates list from api/unicorn/payment/financialserviceproviderxlsxtemplate/

Screenshot 2024-12-31 at 1 13 20 PM

@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Dec 17, 2024
@pavlo-mk pavlo-mk self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 98.44961% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (6bc3969) to head (478f04b).

Files with missing lines Patch % Lines
src/hct_mis_api/apps/payment/mutations.py 95.23% 1 Missing ⚠️
...api/apps/payment/services/payment_plan_services.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4527      +/-   ##
===========================================
- Coverage    84.98%   83.29%   -1.69%     
===========================================
  Files          514      517       +3     
  Lines        36282    36374      +92     
===========================================
- Hits         30833    30297     -536     
- Misses        5449     6077     +628     
Flag Coverage Δ
e2e ?
unittests 83.29% <98.44%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk changed the title WIP // Export xlsx FSP auth code WIP // Export xlsx FSP auth code (MTCN) Jan 2, 2025
@pavlo-mk pavlo-mk requested a review from saxix January 3, 2025 10:49
@mmaciekk mmaciekk self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Change doesn't need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants